Skip to content

fix(e2e-harness): let the final result write replace the outro write - #1340

Merged
gewenyu99 merged 1 commit into
mainfrom
posthog/fix-1333-result-tail
Sep 25, 2026
Merged

gewenyu99 merged 1 commit into
mainfrom
posthog/fix-1333-result-tail

Conversation

@gewenyu99

Copy link
Copy Markdown
Collaborator

Problem

The real-TUI host writes result.json when the outro appears, and a resultWritten guard then makes every later write return early. So the final write after keep-skills never lands. For every program whose outro screen id is outro, screenPath stops at outro and skillsComplete stays false, even when mcp, slack-connect and keep-skills ran. The workbench wizard-ci --e2e checks read both fields.

Part of #1333 (item 4).

Changes

  • createE2eResultWriter. Writes the first outcome once, and only a final write replaces it.
  • tui-host. Builds the payload in buildResult, and ends with writeResult(true).

Nothing flows here. The host's inline guard moves into e2e-result.ts, where it can be tested. It's the same writer the refactor stack adds in #1308, so the two converge.

Test plan

A test in e2e-result.test.ts writes an outro result, checks that a plain write doesn't replace it, and checks that the final write does. It failed on main and passes with the fix.

pnpm typecheck, pnpm lint (0 errors) and pnpm test (199 files, 3350 tests) pass.

LLM context

Written by Claude Code while triaging the real-TUI sweep issues.

Created with PostHog Desktop

The host writes result.json when the outro appears, and a guard then made
every later write return early. So the final write after keep-skills
never ran, and for every program whose outro screen id is `outro`,
`screenPath` stopped at `outro` and `skillsComplete` stayed false, even
when mcp, slack-connect and keep-skills ran.

This ports `createE2eResultWriter` from the refactor stack (#1308): the
first outcome is written once, and only the final write may replace it.

Part of #1333

Generated-By: PostHog Desktop
Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
@github-actions

Copy link
Copy Markdown

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci ai-observability
  • /wizard-ci basic-integration
  • /wizard-ci feature-flags
  • /wizard-ci mcp-analytics
  • /wizard-ci replay-vision
  • /wizard-ci revenue
  • /wizard-ci self-driving
  • /wizard-ci warehouse
  • /wizard-ci warehouse-seeded

Test an individual app:

  • /wizard-ci ai-observability/anthropic
  • /wizard-ci ai-observability/google-adk
  • /wizard-ci ai-observability/groq
Show more apps
  • /wizard-ci ai-observability/manual-capture
  • /wizard-ci ai-observability/openai
  • /wizard-ci ai-observability/openai-agents
  • /wizard-ci ai-observability/opentelemetry
  • /wizard-ci ai-observability/vercel-ai
  • /wizard-ci basic-integration/android
  • /wizard-ci basic-integration/angular
  • /wizard-ci basic-integration/astro
  • /wizard-ci basic-integration/django
  • /wizard-ci basic-integration/fastapi
  • /wizard-ci basic-integration/flask
  • /wizard-ci basic-integration/flutter
  • /wizard-ci basic-integration/javascript-node
  • /wizard-ci basic-integration/javascript-web
  • /wizard-ci basic-integration/laravel
  • /wizard-ci basic-integration/next-js
  • /wizard-ci basic-integration/nuxt
  • /wizard-ci basic-integration/python
  • /wizard-ci basic-integration/rails
  • /wizard-ci basic-integration/react-native
  • /wizard-ci basic-integration/react-router
  • /wizard-ci basic-integration/sveltekit
  • /wizard-ci basic-integration/swift
  • /wizard-ci basic-integration/tanstack-router
  • /wizard-ci basic-integration/tanstack-start
  • /wizard-ci basic-integration/vue
  • /wizard-ci feature-flags/django
  • /wizard-ci feature-flags/next-js
  • /wizard-ci mcp-analytics/custom-dispatcher
  • /wizard-ci mcp-analytics/typescript-sdk
  • /wizard-ci replay-vision/javascript-node
  • /wizard-ci replay-vision/next-js
  • /wizard-ci replay-vision/react-vite
  • /wizard-ci revenue/stripe
  • /wizard-ci self-driving/astro
  • /wizard-ci self-driving/fastapi
  • /wizard-ci self-driving/nuxt
  • /wizard-ci self-driving/react-router
  • /wizard-ci self-driving/sveltekit
  • /wizard-ci warehouse/monorepo-env
  • /wizard-ci warehouse/multi-source-next
  • /wizard-ci warehouse/stripe-node
  • /wizard-ci warehouse/zero-source
  • /wizard-ci warehouse-seeded/next-stripe
  • /wizard-ci warehouse-seeded/next-stripe-declined

Test against a Context Mill branch:

  • /wizard-ci all context-mill:my-branch

Add context-mill:<branch> to any command above to pin the Context Mill branch. It defaults to main.

Results will be posted here when complete.

@gewenyu99
gewenyu99 marked this pull request as ready for review September 24, 2026 22:35
@gewenyu99
gewenyu99 requested a review from a team as a code owner September 24, 2026 22:35

@johncwaters johncwaters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Automated review. Not written by a human.

Verdict: APPROVE

@gewenyu99
gewenyu99 merged commit da1e7ca into main Sep 25, 2026
21 checks passed
@gewenyu99
gewenyu99 deleted the posthog/fix-1333-result-tail branch September 25, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants