Repository navigation
fix(e2e-harness): let the final result write replace the outro write - #1340
Merged
Merged
Conversation
The host writes result.json when the outro appears, and a guard then made every later write return early. So the final write after keep-skills never ran, and for every program whose outro screen id is `outro`, `screenPath` stopped at `outro` and `skillsComplete` stayed false, even when mcp, slack-connect and keep-skills ran. This ports `createE2eResultWriter` from the refactor stack (#1308): the first outcome is written once, and only the final write may replace it. Part of #1333 Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
johncwaters
approved these changes
Sep 25, 2026
johncwaters
left a comment
Contributor
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Verdict: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The real-TUI host writes
result.jsonwhen the outro appears, and aresultWrittenguard then makes every later write return early. So the final write after keep-skills never lands. For every program whose outro screen id isoutro,screenPathstops atoutroandskillsCompletestays false, even when mcp, slack-connect and keep-skills ran. The workbenchwizard-ci --e2echecks read both fields.Part of #1333 (item 4).
Changes
createE2eResultWriter. Writes the first outcome once, and only a final write replaces it.tui-host. Builds the payload inbuildResult, and ends withwriteResult(true).Nothing flows here. The host's inline guard moves into
e2e-result.ts, where it can be tested. It's the same writer the refactor stack adds in #1308, so the two converge.Test plan
A test in
e2e-result.test.tswrites an outro result, checks that a plain write doesn't replace it, and checks that the final write does. It failed on main and passes with the fix.pnpm typecheck,pnpm lint(0 errors) andpnpm test(199 files, 3350 tests) pass.LLM context
Written by Claude Code while triaging the real-TUI sweep issues.
Created with PostHog Desktop